linux-kernel - Re: Crash introduced by commit b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are called unconditionally")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Jan 2016 11:55:12 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Linux-pm mailing list <linux-pm@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: Crash introduced by commit b8b2c7d845d5 ("base/platform: assert
 that dev_pm_domain callbacks are called unconditionally")

On Tue, Jan 19, 2016 at 08:07:09PM +0100, Uwe Kleine-König wrote:
> Hello Alan,
> 
> On Tue, Jan 19, 2016 at 01:22:22PM -0500, Alan Stern wrote:
> > 
> > Your commit causes my ASUS laptop to crash during early boot.  The 
> > problem occurs in platform_drv_probe(), affecting both the alarmtimer 
> > and the asus_laptop platform drivers (I can't tell which is the 
> > critical one).
> > 
> > The old code would not call platform_drv_probe() at all, and probing
> > would always succeed immediately because these drivers have no probe
> > routine.  But with the new code, platform_drv_probe() does run.  The
> > call to of_clk_set_defaults() returns -ENODEV, as does the call to
> > dev_pm_domain_attach().  The call to drv->probe() gets skipped, of 
> > course.  The final return value is -ENODEV, and so probing fails.  This 
> > causes the kernel to crash: blank screen, NumLock LED blinking.
> > 
> > The patch below fixes the problem, but I'm not sure that it's the best 
> > solution.  What is your advice?
> You want
> 
> 	http://mid.gmane.org/1449132704-9952-1-git-send-email-martin.wilck@ts.fujitsu.com
> 
> .
> 
> Greg, I'd welcome this fix in mainline and 4.4.x.

Yes it's in my queue to get to after 4.5-rc1 -s out.

thanks,

greg k-h