linux-kernel - Re: [PATCH] infiniband: Replace memset with eth_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <569EA02D.4050604@redhat.com>
Date:	Tue, 19 Jan 2016 15:44:29 -0500
From:	Doug Ledford <dledford@...hat.com>
To:	Lucas Tanure <tanure@...ux.com>,
	Yishai Hadas <yishaih@...lanox.com>
Cc:	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] infiniband: Replace memset with eth_zero_addr

On 01/19/2016 09:06 AM, Lucas Tanure wrote:
> Use eth_zero_addr to assign the zero address to the given address
> array instead of memset when second argument is address of zero.
> 
> Signed-off-by: Lucas Tanure <tanure@...ux.com>
> ---
>  drivers/infiniband/hw/mlx4/ah.c       | 2 +-
>  drivers/infiniband/hw/nes/nes_utils.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/ah.c b/drivers/infiniband/hw/mlx4/ah.c
> index 86af713..44d4164 100644
> --- a/drivers/infiniband/hw/mlx4/ah.c
> +++ b/drivers/infiniband/hw/mlx4/ah.c
> @@ -92,7 +92,7 @@ static struct ib_ah *create_iboe_ah(struct ib_pd *pd, struct ib_ah_attr *ah_attr
>  				ah_attr->grh.sgid_index, &sgid, &gid_attr);
>  	if (ret)
>  		return ERR_PTR(ret);
> -	memset(ah->av.eth.s_mac, 0, ETH_ALEN);
> +	eth_zero_addr(ah->av.eth.s_mac);
>  	if (gid_attr.ndev) {
>  		if (is_vlan_dev(gid_attr.ndev))
>  			vlan_tag = vlan_dev_vlan_id(gid_attr.ndev);
> diff --git a/drivers/infiniband/hw/nes/nes_utils.c b/drivers/infiniband/hw/nes/nes_utils.c
> index 2042c0f..6d3a169 100644
> --- a/drivers/infiniband/hw/nes/nes_utils.c
> +++ b/drivers/infiniband/hw/nes/nes_utils.c
> @@ -727,7 +727,7 @@ int nes_arp_table(struct nes_device *nesdev, u32 ip_addr, u8 *mac_addr, u32 acti
>  	if (action == NES_ARP_DELETE) {
>  		nes_debug(NES_DBG_NETDEV, "DELETE, arp_index=%d\n", arp_index);
>  		nesadapter->arp_table[arp_index].ip_addr = 0;
> -		memset(nesadapter->arp_table[arp_index].mac_addr, 0x00, ETH_ALEN);
> +		eth_zero_addr(nesadapter->arp_table[arp_index].mac_addr);
>  		nes_free_resource(nesadapter, nesadapter->allocated_arps, arp_index);
>  		return arp_index;
>  	}
> 

Thanks, applied.

-- 
Doug Ledford <dledford@...hat.com>
              GPG KeyID: 0E572FDD



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)