linux-kernel - Re: [PATCH] drivers:pci Add pcie/Kconfig to pci/Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jan 2016 21:31:54 -0600
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Bogicevic Sasa <brutallesale@...il.com>
Cc:	bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:pci Add pcie/Kconfig to pci/Kconfig

Hi Bogicevic,

On Tue, Jan 12, 2016 at 06:22:25AM -0800, Bogicevic Sasa wrote:
> Architectures currently have to include both
> drivers/pci/Kconfig and drivers/pci/pcie/Kconfig.
> They should include only drivers/pci/Kconfig, and
> that should handle PCIe as well.
> 
> Signed-off-by: Bogicevic Sasa <brutallesale@...il.com>
> ---
>  drivers/pci/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 73de4ef..005dd7d 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -119,3 +119,5 @@ config PCI_LABEL
>  	select NLS
>  
>  source "drivers/pci/host/Kconfig"
> +
> +source "drivers/pci/pcie/Kconfig"

This project is something I'd like to get done, but it requires a
little more work.  If it were this simple, I would have done it long
ago :)

For one thing, we need to update all the Kconfig files that already
include drivers/pci/pcie/Kconfig at the same time.  On x86,
arch/x86/Kconfig already includes both:

  source "drivers/pci/pcie/Kconfig"
  source "drivers/pci/Kconfig"

With your patch applied, I see these new warnings:

  05:42:09 ~/linux (wip/bogicevic-kconfig)$ make menuconfig
  ...
  scripts/kconfig/mconf  Kconfig
  drivers/pci/pcie/Kconfig:61:warning: choice value used outside its choice group
  drivers/pci/pcie/Kconfig:67:warning: choice value used outside its choice group
  drivers/pci/pcie/Kconfig:74:warning: choice value used outside its choice group

I see that you did verify that removing the source line from
arch/x86/Kconfig does the right thing.  We need to put all the related
changes in a single patch so it is self-contained.  The tree should be
buildable and functional at every stage.

Bjorn