linux-kernel - Re: [PATCH] fix CONFIG_IO_STRICT_DEVMEM, do not enable by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+Z5hV=nVmhT0A1Uiv4jY6VbM8PFX-h55bFHvdFVM28Vw@mail.gmail.com>
Date:	Wed, 20 Jan 2016 15:12:43 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] fix CONFIG_IO_STRICT_DEVMEM, do not enable by default

On Wed, Jan 20, 2016 at 2:37 PM, Dan Williams <dan.j.williams@...el.com> wrote:
> Larry reports: "My PowerBook G4 Aluminum with a 32-bit PPC processor
> fails to boot for the 4.4-git series".  This is likely due to X still
> needing /dev/mem access on this platform.
>
> CONFIG_IO_STRICT_DEVMEM is not yet safe to turn on when
> CONFIG_STRICT_DEVMEM=y.  Remove the default so that old configurations
> do not change behavior.
>
> Fixes: 90a545e98126 ("restrict /dev/mem to idle io memory ranges")
> Reported-by: Larry Finger <Larry.Finger@...inger.net>
> Tested-by: Larry Finger <Larry.Finger@...inger.net>
> Link: http://marc.info/?l=linux-kernel&m=145332012023825&w=2
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Acked-by: Kees Cook <keescook@...omium.org>

This should probably be CC: stable, yes?

-Kees

> ---
>  lib/Kconfig.debug |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index f75a33f29f6e..7d0b49c536c5 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1919,7 +1919,6 @@ config STRICT_DEVMEM
>  config IO_STRICT_DEVMEM
>         bool "Filter I/O access to /dev/mem"
>         depends on STRICT_DEVMEM
> -       default STRICT_DEVMEM
>         ---help---
>           If this option is disabled, you allow userspace (root) access to all
>           io-memory regardless of whether a driver is actively using that
>



-- 
Kees Cook
Chrome OS & Brillo Security