linux-kernel - Re: [PATCH] x86: static_cpu_has_safe: discard dynamic check after init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <569F1022.6040709@zytor.com>
Date:	Tue, 19 Jan 2016 20:42:10 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Brian Gerst <brgerst@...il.com>
Cc:	Borislav Petkov <bp@...e.de>,
	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] x86: static_cpu_has_safe: discard dynamic check after
 init

On 01/19/16 20:39, Brian Gerst wrote:
> 
> Can't put it in .init.text or else you get:
> WARNING: arch/x86/kernel/built-in.o(.text+0x4b9): Section mismatch in
> reference from the function __switch_to() to the (unknown reference)
> .init.text:(unknown)
> The function __switch_to() references
> the (unknown reference) __init (unknown).
> This is often because __switch_to lacks a __init
> annotation or the annotation of (unknown) is wrong.
> 
> We want to override that because we know that the reference will be
> removed after alternatives run.  That's why I created a new section.
> 

Right.  I wish we could tag reference call sites as clean, not sources
or targets.  Sigh.

However, that's not too much of an issue.

	-hpa