linux-kernel - Re: [PATCH] thermal: core: don't call unsupported trip on thermal_tripped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87poww3edk.wl%kuninori.morimoto.gx@renesas.com>
Date:	Wed, 20 Jan 2016 07:25:01 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	Eduardo Valentin <edubezval@...il.com>,
	Zhang Rui <rui.zhang@...el.com>, Simon <horms@...ge.net.au>,
	Magnus <magnus.damm@...il.com>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	<linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] thermal: core: don't call unsupported trip on thermal_tripped_notify()


Hi Geert

> > From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> >
> > It needs to check maximum trip size before using it.
> > Otherwise, each driver might be called with unsupported trip.
> >
> > Reported-by: Magnus Damm <magnus.damm@...il.com>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> > ---
> >  drivers/thermal/thermal_core.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> > index 7f7a3ca..9761f49 100644
> > --- a/drivers/thermal/thermal_core.c
> > +++ b/drivers/thermal/thermal_core.c
> > @@ -461,6 +461,9 @@ static void thermal_tripped_notify(struct thermal_zone_device *tz,
> >                 kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, msg);
> >         }
> >
> > +       if (tz->trips <= trip + 1)
> > +               goto unlock;
> > +
> 
> Thanks, I assume this will fix the "rcar_thermal e61f0000.thermal: rcar
> driver trip error" messages.
> 
> However, I don't know if it's the right fix, cfr. my unanswered question at
> https://lkml.org/lkml/2016/1/5/107
> 
> >         ret = tz->ops->get_trip_temp(tz, trip + 1, &upper_trip_temp);
> >         if (ret)
> >                 goto unlock;

Yes. we have 2 solutions.
     1) use this patch
     2) dev_warn() -> dev_dbg()
But my opinion is that using trip with +1 without checking supported size
is strange :)