linux-kernel - Re: [PATCH v5 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d1swvgv8.fsf@dell.be.48ers.dk>
Date:	Wed, 20 Jan 2016 08:40:11 +0100
From:	Peter Korsgaard <peter@...sgaard.com>
To:	"Yang\, Wenyou" <Wenyou.Yang@...el.com>
Cc:	Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
	"Pawel Moll" <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	"Ian Campbell" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"devicetree\@vger.kernel.org" <devicetree@...r.kernel.org>,
	"Krzysztof Kozlowski" <k.kozlowski@...sung.com>,
	"Ferre\, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	Javier Martinez Canillas <javier@...hile0.org>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

>>>>> "Yang," == Yang, Wenyou <Wenyou.Yang@...el.com> writes:

Hi,

>> But the charger driver can just as well do:
 >> 
 >> dev_get_regmap(dev->parent);
 >> 
 >> instead of:
 >> 
 >> dev_get_drvdata(pdev->dev.parent)->regmap.

 > For regulator, it works use the core do dev_get_regmap(dev->parent),
 > but for charger, it need to export *act8945a.

Why?

Just like the regulator core does, your battery driver can do:

dev_get_regmap(dev->parent);

-- 
Venlig hilsen,
Peter Korsgaard