linux-kernel - Re: [PATCH] NVMe: init nvme queue before enabling irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <569F59B1.3040207@dev.mellanox.co.il>
Date:	Wed, 20 Jan 2016 11:56:01 +0200
From:	Sagi Grimberg <sagig@....mellanox.co.il>
To:	Wenbo Wang <wenbo.wang@...blaze.com>,
	Johannes Thumshirn <jthumshirn@...e.de>,
	Wenbo Wang <mail_weber_wang@....com>
Cc:	"keith.busch@...el.com" <keith.busch@...el.com>,
	"axboe@...com" <axboe@...com>,
	"Wenwei.Tao" <wenwei.tao@...blaze.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH] NVMe: init nvme queue before enabling irq


>> If it can cause a kernel panic shouldn't it go through stable then as well?
>
> Sorry, not quite understand this comment.
> The "reset process" is the nvme device reset process (performed by nvme_reset_work()) triggered by device fail condition.
> During normal boot up, nvmeq door bell is initialized in nvme_alloc_queue() which happens before enabling irq, so there is no error.
> During nvme device reset process, nvme_alloc_queue() is skipped and the race condition exists.

I think what Johannes meant was that this patch should include a
"CC: stable@...r.kernel.org" tag.