linux-kernel - Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160120114635.GA6588@sirena.org.uk>
Date:	Wed, 20 Jan 2016 11:46:35 +0000
From:	Mark Brown <broonie@...nel.org>
To:	chenfeng <puck.chen@...ilicon.com>
Cc:	lee.jones@...aro.org, lgirdwood@...il.com,
	linux-kernel@...r.kernel.org, yudongbin@...ilicon.com,
	saberlily.xia@...ilicon.com, suzhuangluan@...ilicon.com,
	kong.kongxinwei@...ilicon.com, xuyiping@...ilicon.com,
	z.liuxinliang@...ilicon.com, weidong2@...ilicon.com,
	w.f@...wei.com, puck.chen@...mail.com, shimingxing@...ilicon.com,
	oliver.fu@...ilicon.com, albert.lubing@...ilicon.com,
	chenxiang9@...wei.com, liuzixing@...wei.com,
	haojian.zhuang@...aro.org, qijiwen@...ilicon.com,
	peter.panshilin@...ilicon.com, dan.zhao@...ilicon.com,
	linuxarm@...wei.com, dev@...ts.96boards.org
Subject: Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core

On Wed, Jan 20, 2016 at 11:51:27AM +0800, chenfeng wrote:

> I will change it like this:
> bindings: regulator: hi655x: Document for hi655x regulator driver

As we discussed previously I'd expected something more like:

     regulator: hi655x: Document for hi655x regulator driver

> arm64: dts: hisilicon: Add hi655x pmic dts node

That's what I'd expect.  

> Have you also reviewed the regulator driver code? I changed it to
> of_match and regulators_node without opening code.

Not yet.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)