linux-kernel - Re: [PATCH v4 1/2] power: act8945a: add charger driver for ACT8945A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABxcv=ndbsEjAvA9gyfM9CPFNu2MOVgG0QhiKtRB_fA9yiuMXg@mail.gmail.com>
Date:	Wed, 20 Jan 2016 09:18:09 -0300
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH v4 1/2] power: act8945a: add charger driver for ACT8945A

Hello Wenyou,

On Wed, Jan 20, 2016 at 4:24 AM, Yang, Wenyou <Wenyou.Yang@...el.com> wrote:

[snip]

>> > +}
>> > +
>> > +static struct platform_driver act8945a_charger_driver = {
>> > +   .driver = {
>> > +           .name = "act8945a-charger",
>> > +   },
>> > +   .probe  = act8945a_charger_probe,
>> > +};
>> > +module_platform_driver(act8945a_charger_driver);
>>
>> Is your driver auto-loaded properly when built as a module? By auto-loading I
>> mean auto-loaded by udev, not by putting to some rc-script or other modprobe-
>> load scripts.
>>
>
> I failed to configure auto-loaded in rootfs generated by buildroot. I need time to dig it.
>
> Anyway I add OF match table.
>

If you don't have udev/kmod working on your system, you can check if
the modalias reported in the driver's uevent sysfs entry is a valid
alias in the kernel module, i.e:

$ grep MODALIAS $(find -name uevent | grep act8945a-charger)
$ modinfo act8945a_charger | grep alias

>
> Best Regards,
> Wenyou Yang

Best regards,
Javier