linux-kernel - Re: [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc

Open Source and information security mailing list archives

Message-ID: <20160120125652.GC23290@intel.com>
Date:	Wed, 20 Jan 2016 14:56:52 +0200
From:	Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:	Colin King <colin.king@...onical.com>
Cc:	Dave Airlie <airlied@...hat.com>, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/fb_cma_helper: remove duplicate const from
 drm_fb_cma_alloc

On Wed, Jan 20, 2016 at 10:59:34AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Duplicated const, only one is required.  Also reformat line to ensure
> it is less than 80 columns wide.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..bb88e3d 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,8 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
>  };
>  
>  static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> -	const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> +	const struct drm_mode_fb_cmd2 *mode_cmd,
> +	struct drm_gem_cma_object **obj,

Seems to have been my mode_cmd constification that added the second
const by accident.

Reviewed-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>

>  	unsigned int num_planes)
>  {
>  	struct drm_fb_cma *fb_cma;
> -- 
> 2.7.0.rc3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives