linux-kernel - [PATCH v2] mm:mempolicy: skip VM_HUGETLB and VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jan 2016 22:07:28 +0800
From:	Liang Chen <liangchen.linux@...il.com>
To:	rientjes@...gle.com, linux-mm@...ck.org
Cc:	n-horiguchi@...jp.nec.com, riel@...hat.com, mgorman@...e.de,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Liang Chen <liangchen.linux@...il.com>,
	Gavin Guo <gavin.guo@...onical.com>
Subject: [PATCH v2] mm:mempolicy: skip VM_HUGETLB and VM_MIXEDMAP VMA for lazy mbind

VM_HUGETLB and VM_MIXEDMAP vma needs to be excluded to avoid compound
pages being marked for migration and unexpected COWs when handling
hugetlb fault.

Thanks to Naoya Horiguchi for reminding me on these checks.

Signed-off-by: Liang Chen <liangchen.linux@...il.com>
Signed-off-by: Gavin Guo <gavin.guo@...onical.com>
Suggested-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
---
Changes since v2:
- Add Suggested-by tag to give credit to Naoya Horiguchi for the idea

---
 mm/mempolicy.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 436ff411..415de70 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -610,8 +610,9 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
 
 	if (flags & MPOL_MF_LAZY) {
 		/* Similar to task_numa_work, skip inaccessible VMAs */
-		if (vma_migratable(vma) &&
-			vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
+		if (vma_migratable(vma) && !is_vm_hugetlb_page(vma) &&
+			(vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE)) &&
+			!(vma->vm_flags & VM_MIXEDMAP))
 			change_prot_numa(vma, start, endvma);
 		return 1;
 	}
-- 
1.9.1