linux-kernel - Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <569FAF47.4070405@redhat.com>
Date:	Wed, 20 Jan 2016 17:01:11 +0100
From:	Tomas Henzl <thenzl@...hat.com>
To:	Johannes Thumshirn <jthumshirn@...e.de>,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	James Smart <james.smart@...gotech.com>,
	Dick Kennedy <dick.kennedy@...gotech.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lpfc: Remove redundant code block in
 lpfc_scsi_cmd_iocb_cmpl

On 20.1.2016 16:08, Johannes Thumshirn wrote:
> This removes a redundant code block that will either be executed if the
> ENABLE_FCP_RING_POLLING flag is set in phba->cfg_poll or not. The code is just
> duplicated in both cases, hence we unify it again.
>
> This probably is a left over from some sort of refactoring.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>

Reviewed-by: Tomas Henzl <thenzl@...hat.com>

Tomas

> ---
>  drivers/scsi/lpfc/lpfc_scsi.c | 17 -----------------
>  1 file changed, 17 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
> index 152b3c8..3bd0be6 100644
> --- a/drivers/scsi/lpfc/lpfc_scsi.c
> +++ b/drivers/scsi/lpfc/lpfc_scsi.c
> @@ -4139,23 +4139,6 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
>  	/* The sdev is not guaranteed to be valid post scsi_done upcall. */
>  	cmd->scsi_done(cmd);
>  
> -	if (phba->cfg_poll & ENABLE_FCP_RING_POLLING) {
> -		spin_lock_irqsave(&phba->hbalock, flags);
> -		lpfc_cmd->pCmd = NULL;
> -		spin_unlock_irqrestore(&phba->hbalock, flags);
> -
> -		/*
> -		 * If there is a thread waiting for command completion
> -		 * wake up the thread.
> -		 */
> -		spin_lock_irqsave(shost->host_lock, flags);
> -		if (lpfc_cmd->waitq)
> -			wake_up(lpfc_cmd->waitq);
> -		spin_unlock_irqrestore(shost->host_lock, flags);
> -		lpfc_release_scsi_buf(phba, lpfc_cmd);
> -		return;
> -	}
> -
>  	spin_lock_irqsave(&phba->hbalock, flags);
>  	lpfc_cmd->pCmd = NULL;
>  	spin_unlock_irqrestore(&phba->hbalock, flags);