linux-kernel - Re: [PATH v2] NVMe: init nvme queue before enabling irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <569FC116.5060109@fb.com>
Date:	Wed, 20 Jan 2016 10:17:10 -0700
From:	Jens Axboe <axboe@...com>
To:	Greg KH <gregkh@...uxfoundation.org>,
	Wenbo Wang <mail_weber_wang@....com>
CC:	<keith.busch@...el.com>, <linux-kernel@...r.kernel.org>,
	<linux-nvme@...ts.infradead.org>, <wenwei.tao@...blaze.com>,
	<stable@...r.kernel.org>, Wenbo Wang <wenbo.wang@...blaze.com>
Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq

On 01/20/2016 10:12 AM, Greg KH wrote:
> On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote:
>> From: Wenbo Wang <wenbo.wang@...blaze.com>
>>
>> During reset process, the nvme_dev->bar (ioremapped) may change,
>> so nvmeq->q_db shall be also updated by nvme_init_queue().
>>
>> Currently nvmeq irq is enabled before queue init, so a spurious
>> interrupt triggered nvme_process_cq may access nvmeq->q_db just
>> before it is updated, this could cause kernel panic.
>>
>> Signed-off-by: Wenbo Wang <wenbo.wang@...blaze.com>
>> Reviewed-by: Wenwei Tao <wenwei.tao@...blaze.com>
>> ---
>>   drivers/nvme/host/pci.c | 14 +++++++++-----
>>   1 file changed, 9 insertions(+), 5 deletions(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.

I'll mark it stable when adding, just ignore it for now.

-- 
Jens Axboe