linux-kernel - Re: [PATCH] usb: phy-am335x: clarify USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160120180833.GA5433@uda0271908>
Date:	Wed, 20 Jan 2016 12:08:33 -0600
From:	Bin Liu <b-liu@...com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Felipe Balbi <balbi@...com>, <balbif@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency

Hi,

On Wed, Jan 20, 2016 at 11:56:34AM +0100, Arnd Bergmann wrote:
> The phy-am335x driver accidentally selects 'USB_COMMON', which is
> not correct as that symbol should indicate whether USB host or
> target mode is enabled, but it might not:
> 
> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))

Is it possible to have a .config which has either USB nor USB_GADGET
set but AM335X_PHY_USB is set to be in the situation as in the warning
above?

> 
> This changes the 'select' into 'depends on', as it should have
> been initially.

Using 'depends on' causes AM335x_PHY_USB driver unable to built-in,
since USB_COMMON is an invisible option and its defualt is 'M'.

Regards,
-Bin.

> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")
> 
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index c6904742e2aa..29f063c59e1a 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -63,10 +63,10 @@ config AM335X_CONTROL_USB
>  config AM335X_PHY_USB
>  	tristate "AM335x USB PHY Driver"
>  	depends on ARM || COMPILE_TEST
> +	depends on USB_COMMON
>  	select USB_PHY
>  	select AM335X_CONTROL_USB
>  	select NOP_USB_XCEIV
> -	select USB_COMMON
>  	help
>  	  This driver provides PHY support for that phy which part for the
>  	  AM335x SoC.
>