linux-kernel - Re: [PATCH 1/2] Staging:lustre:obdclass:linux:remove unnecessary braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Jan 2016 11:06:26 -0800
From:	Joe Perches <joe@...ches.com>
To:	Bhumika Goyal <bhumirks@...il.com>, oleg.drokin@...el.com,
	gregkh@...uxfoundation.org
Cc:	andreas.dilger@...el.com, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org, lustre-devel@...ts.lustre.org
Subject: Re: [PATCH 1/2] Staging:lustre:obdclass:linux:remove unnecessary
 braces

On Thu, 2016-01-21 at 00:17 +0530, Bhumika Goyal wrote:
> Fixed 'braces {} are not necessary for single statement blocks'
> checkpatch.pl warning.
[]
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
[]
> @@ -144,9 +144,8 @@ int obd_ioctl_getdata(char **buf, int *len, void *arg)
>  		offset += cfs_size_round(data->ioc_inllen3);
>  	}
>  
> -	if (data->ioc_inllen4) {
> +	if (data->ioc_inllen4)
>  		data->ioc_inlbuf4 = &data->ioc_bulk[0] + offset;

You might also consider converting uses of &foo[0] to foo