linux-kernel - Re: [4.4-rt2 PATCH] ARM: highmem: take into account FIX_KMAP_BEGIN in switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160120202139.GC2741@linutronix.de>
Date:	Wed, 20 Jan 2016 21:21:39 +0100
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Grygorii Strashko <grygorii.strashko@...com>
Cc:	Russell King <rmk+kernel@....linux.org.uk>,
	linux-rt-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, Sekhar Nori <nsekhar@...com>
Subject: Re: [4.4-rt2 PATCH] ARM: highmem: take into account FIX_KMAP_BEGIN
 in switch_kmaps()

* Grygorii Strashko | 2016-01-15 16:20:47 [+0200]:

>--- a/arch/arm/mm/highmem.c
>+++ b/arch/arm/mm/highmem.c
>@@ -175,7 +180,7 @@ void switch_kmaps(struct task_struct *prev_p, struct task_struct *next_p)
> 	 * Restore @next_p's kmap_atomic mappings
> 	 */
> 	for (i = 0; i < next_p->kmap_idx; i++) {
>-		int idx = i + KM_TYPE_NR * smp_processor_id();
>+		int idx = fixmap_idx(i);
> 
> 		if (!pte_none(next_p->kmap_pte[i]))
> 			set_fixmap_pte(idx, next_p->kmap_pte[i]);

Grygorii, if you remove this chunk then it should apply upstream. Could
you forward it upstream then please? So the -RT piece would shrink a
little:)

Sebastian