linux-kernel - Re: [RFC v1 3/8] x86/boot: add BIT() to boot/bitops.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAB=NE6Xnye50WxW0xVebeL8A0Hd_cj7JLWAgtkeooGx5wCWQ_A@mail.gmail.com>
Date:	Wed, 20 Jan 2016 12:33:46 -0800
From:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andy Lutomirski <luto@...capital.net>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>, mcb30@...e.org,
	Juergen Gross <jgross@...e.com>,
	Jan Beulich <JBeulich@...e.com>, joro@...tes.org,
	Andrey Ryabinin <ryabinin.a.a@...il.com>,
	andreyknvl@...gle.com, long.wanglong@...wei.com,
	qiuxishi@...wei.com, aryabinin@...tuozzo.com,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Valentin Rothberg <valentinrothberg@...il.com>,
	Peter Senna Tschudin <peter.senna@...il.com>,
	X86 ML <x86@...nel.org>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC v1 3/8] x86/boot: add BIT() to boot/bitops.h

On Wed, Jan 20, 2016 at 12:17 PM, Konrad Rzeszutek Wilk
<konrad.wilk@...cle.com> wrote:
> Where? Could you paste in the name of the patch in the description?

+x86_init_early(BIT(X86_SUBARCH_INTEL_MID), NULL, NULL,
+              x86_intel_mid_early_setup);

Is an example, so users of the subarch. Likewise the macro helpers to
make these smaller, see x86_init_early_all() on the patch "x86/init:
add linker table support".

And then of course the checkers:

+static bool x86_init_fn_supports_subarch(struct x86_init_fn *fn)
+{
+       if (!fn->supp_hardware_subarch) {
+               pr_err("Init sequence fails to declares any supported
subarchs: %pF\n", fn->early_init);
+               WARN_ON(1);
+       }
+       if (BIT(boot_params.hdr.hardware_subarch) & fn->supp_hardware_subarch)
+               return true;
+       return false;
+}

  Luis