linux-kernel - Re: [PATCH] usb: dwc2: hcd: fix periodic transfer schedule sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Jan 2016 16:23:01 -0800
From:	Doug Anderson <dianders@...omium.org>
To:	John Youn <John.Youn@...opsys.com>
Cc:	Julius Werner <jwerner@...gle.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	wulf <wulf@...k-chips.com>,
	Kever Yang <kever.yang@...k-chips.com>,
	frank.wang@...k-chips.com, Tao Huang <huangtao@...k-chips.com>,
	Caesar Wang <caesar.upstream@...il.com>
Subject: Re: [PATCH] usb: dwc2: hcd: fix periodic transfer schedule sequence

John,

On Mon, Nov 16, 2015 at 2:41 PM, Caesar Wang <caesar.upstream@...il.com> wrote:
> Hi,
>
> 在 2015年11月16日 23:25, Yunzhi Li 写道:
>>
>> When checking dwc2 host channel interrupts, handle qh in
>> periodic_sched_queued list at first, then we could make sure CSPLIT
>> packets scheduled in the same order as SSPLIT packets.
>>
>> Signed-off-by: Yunzhi Li <lyz@...k-chips.com>
>
>
> This patch can fix some usb issues on my hand machine.
>
> Says:
> (1) The usb hub can't normal work (KB, mouse ...) when SB headset/Speaker is
> connected to USB2.0 travel HUB.
> (2)  The music have the wonder noise when we are use some usb speak.
> ......
>
> So, you can free add my test tag:
>
> Tested-by: Caesar Wang <wxt@...k-chips.com>
>
>
>> ---
>>   drivers/usb/dwc2/hcd_intr.c | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)

Just FYI that I'm planning to send up a new version of this patch.
Though we've been carrying it in our Chrome OS tree and it's been
helping, in my reboot tests I did just find a crash right in the code
that this patch is adding.  Apparently "qh->channel" is NULL in at
least some case in the loop.  This seems like something that could
have happened if dwc2_deactivate_qh() was called and then we got an
interrupt after.

I also realized that it's probably important to get order right even
for non-periodic splits.  lyz's patch only handled periodic splits...


-Doug