linux-kernel - Re: [PATCH v3 1/6] clk: mediatek: Refine the makefile to support multiple clock drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1453343300.28078.6.camel@mtksdaap41>
Date:	Thu, 21 Jan 2016 10:28:20 +0800
From:	Yingjoe Chen <yingjoe.chen@...iatek.com>
To:	James Liao <jamesjj.liao@...iatek.com>
CC:	Matthias Brugger <matthias.bgg@...il.com>,
	Mike Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"John Crispin" <blogic@...nwrt.org>, <devicetree@...r.kernel.org>,
	Sascha Hauer <kernel@...gutronix.de>,
	<srv_heupstream@...iatek.com>, <linux-kernel@...r.kernel.org>,
	<linux-mediatek@...ts.infradead.org>,
	"Shunli Wang" <shunli.wang@...iatek.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	<linux-clk@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 1/6] clk: mediatek: Refine the makefile to support
 multiple clock drivers

On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote:
> Add a Kconfig to define clock configuration for each SoC, and
> modify the Makefile to build drivers that only selected in config.
> 
> Signed-off-by: Shunli Wang <shunli.wang@...iatek.com>
> Signed-off-by: James Liao <jamesjj.liao@...iatek.com>
> ---
>  drivers/clk/Kconfig           |  1 +
>  drivers/clk/mediatek/Kconfig  | 23 +++++++++++++++++++++++
>  drivers/clk/mediatek/Makefile |  6 +++---
>  3 files changed, 27 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/clk/mediatek/Kconfig
> 
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index c3e3a02..b7a37dc 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -198,3 +198,4 @@ source "drivers/clk/mvebu/Kconfig"
>  
>  source "drivers/clk/samsung/Kconfig"
>  source "drivers/clk/tegra/Kconfig"
> +source "drivers/clk/mediatek/Kconfig"


Hi James,

drivers/clk/mediatek/Kconfig add user selectable options, menuconfig
will list them outside of "Common Clock Framework" sub-menu if you
source the file here. Kconfig for samsung & tegra doesn't have any, so
it is OK for them to stay here.

Please move it inside the menu, also it seems the source lines are
sorted now, so let's keep them sorted.

Joe.C