linux-kernel - Re: [PATCH] 8250: uniphier: allow modular build with 8250 console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATVtLk6UTh+r9JTZrKq-veEXetDdRutZ_=zQOd-WyAO0g@mail.gmail.com>
Date:	Thu, 21 Jan 2016 20:39:03 +0900
From:	Masahiro Yamada <yamada.masahiro@...ionext.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter Hurley <peter@...leysoftware.com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-serial@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] 8250: uniphier: allow modular build with 8250 console

Hi Arnd,


2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@...db.de>:
> The recently added uniphier 8250 port driver supports early console
> probing, and it supports being built as a module, but the combination
> of the two fails to link:
>
> ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>
> Given that earlycon support in a loadable module makes no sense,
> making that code conditional on 'MODULE' is a correct solution.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>
> diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
> index bab6b3ae2540..1b7bd26555b7 100644
> --- a/drivers/tty/serial/8250/8250_uniphier.c
> +++ b/drivers/tty/serial/8250/8250_uniphier.c
> @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>         spinlock_t atomic_write_lock;
>  };
>
> -#ifdef CONFIG_SERIAL_8250_CONSOLE
> +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>  static int __init uniphier_early_console_setup(struct earlycon_device *device,
>                                                const char *options)
>  {
>
>


If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
this build error will be fixed as well.  But I doubt it is accepted soon...

So, I am OK with this workaround to fix "make allmodconfig".

Acked-by: Masahiro Yamada <yamada.masahiro@...ionext.com>



-- 
Best Regards
Masahiro Yamada