linux-kernel - Re: [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y4bjyx39.fsf@kamboji.qca.qualcomm.com>
Date:	Thu, 21 Jan 2016 13:46:02 +0200
From:	Kalle Valo <kvalo@....qualcomm.com>
To:	Rob Herring <robh@...nel.org>
CC:	Raja Mani <rmani@....qualcomm.com>, <devicetree@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <ath10k@...ts.infradead.org>,
	<agross@...eaurora.org>
Subject: Re: [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block

Rob Herring <robh@...nel.org> writes:

> On Wed, Jan 13, 2016 at 11:26:44AM +0530, Raja Mani wrote:
>> Add device tree binding documentation details for wifi block present
>> in Qualcomm IPQ4019 SoC into "qcom,ath10k.txt".
>> 
>> Right now, ath10k wireless driver has support for PCI based wlan devices.
>> There is a plan to extend ath10k driver to support wifi devices which are
>> connected over AHB as well (enumeration will happen via device tree node).
>> For AHB based devices (ie, ipq4019), all wifi properties are supplied via
>> device tree (including irq, reg addr, cal data,etc).
>> 
>> Signed-off-by: Raja Mani <rmani@....qualcomm.com>
>> ---
>> v3 changes:
>>   - Removed core-id - [Rob]
>>   - Documented which compatible string corresponds to pci devices
>>     and which corresponds to ahb devices. - [Rob]
>> 
>> v2 changes:
>>  - Improved "core-id" description - [Rob]
>>  - Removed "status" documentation - [Rob]
>>  - Added description which properties are applicable
>>    for ahb and which are applicable for pci devices - [Rob]
>>  - Improved commit msg to explain the context.
>>  - Renamed "qca,msi_addr" to "qcom,msi_addr" and
>>    "qca,msi_base" to "qcom,msi_base" to follow uniformity.
>> 
>>  .../bindings/net/wireless/qcom,ath10k.txt          | 89 ++++++++++++++++++++--
>>  1 file changed, 84 insertions(+), 5 deletions(-)
>
> A few typos, otherwise:
>
> Acked-by: Rob Herring <robh@...nel.org>

Rob, thank you for the review. I fixed the typos in ath.git pending
branch and will properly apply this in few days.

-- 
Kalle Valo