linux-kernel - Re: [PATCH v2 1/1] Support for CMedia CM6533 HID audio jack controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1601211405050.21446@cbobk.fhfr.pm>
Date:	Thu, 21 Jan 2016 14:08:23 +0100 (CET)
From:	Jiri Kosina <jikos@...nel.org>
To:	Ben Chen <ben_chen@...linktech.com>
cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v2 1/1] Support for CMedia CM6533 HID audio jack
 controls

On Wed, 30 Dec 2015, Ben Chen wrote:

> The C-Media CM6533 is a USB audio chip featuring it's jack detection capability.The device originates an interrupt transfer via HID interface each time when a jack event occurs.
> The purpose of this patch is to handle hid raw events to keep the operating system informed of user interactions.
> 
> Signed-off-by: Ben Chen <ben_chen@...linktech.com>
> ---
> Changes in v2:
> - The return type of input_configured callback has been changed from void to be int.
> 
>  drivers/hid/Kconfig      |   6 ++
>  drivers/hid/Makefile     |   1 +
>  drivers/hid/hid-cm6533.c | 168 +++++++++++++++++++++++++++++++++++++++++++++++

We usually name the drivers according to the vendor name. IOW, I'd suggest 
you rename the driver to hid-cmedia.

Thanks,

-- 
Jiri Kosina
SUSE Labs