linux-kernel - Re: [PATCH] IMA: fix non-ANSI declaration of ima_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1453382511.9549.140.camel@linux.vnet.ibm.com>
Date:	Thu, 21 Jan 2016 08:21:51 -0500
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	Colin King <colin.king@...onical.com>
Cc:	Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
	James Morris <james.l.morris@...cle.com>,
	"Serge E . Hallyn" <serge@...lyn.com>,
	linux-ima-devel@...ts.sourceforge.net,
	linux-ima-user@...ts.sourceforge.net,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IMA: fix non-ANSI declaration of ima_check_policy()

On Wed, 2016-01-20 at 11:13 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> ima_check_policy() has no parameters, so use the normal void
> parameter convention to make it match the prototype in the header file
> security/integrity/ima/ima.h
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thank you.

Mimi

> ---
>  security/integrity/ima/ima_policy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
> index 0a3b781..e0e18cc 100644
> --- a/security/integrity/ima/ima_policy.c
> +++ b/security/integrity/ima/ima_policy.c
> @@ -417,7 +417,7 @@ void __init ima_init_policy(void)
>  }
> 
>  /* Make sure we have a valid policy, at least containing some rules. */
> -int ima_check_policy()
> +int ima_check_policy(void)
>  {
>  	if (list_empty(&ima_temp_rules))
>  		return -EINVAL;