linux-kernel - Re: [PATCH] Remove logging for "Unsupported brightness interface"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Jan 2016 11:54:43 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Eric Curtin <ericcurtin17@...il.com>,
	platform-driver-x86@...r.kernel.org
Cc:	ibm-acpi-devel@...ts.sourceforge.net,
	Darren Hart <dvhart@...radead.org>, ibm-acpi@....eng.br,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Remove logging for "Unsupported brightness interface"

On Thu, Jan 21, 2016, at 09:18, Eric Curtin wrote:
> On 16 January 2016 at 23:43, Eric Curtin <ericcurtin17@...il.com> wrote:
> > Message gets logged on machines that are well supported.
> > Fixed one checkpatch.pl ERROR also.
> >
> > Signed-off-by: Eric Curtin <ericcurtin17@...il.com>
> > ---
> >  drivers/platform/x86/thinkpad_acpi.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c
> > b/drivers/platform/x86/thinkpad_acpi.c
> > index 0bed473..b149dec 100644
> > --- a/drivers/platform/x86/thinkpad_acpi.c
> > +++ b/drivers/platform/x86/thinkpad_acpi.c
> > @@ -6434,7 +6434,7 @@ static const struct tpacpi_quirk
> > brightness_quirk_table[] __initconst = {
> >   */
> >  static void __init tpacpi_detect_brightness_capabilities(void)
> >  {
> > - unsigned int b;
> > + const unsigned int b = tpacpi_check_std_acpi_brightness_support();

This unrelated change can have side-effects, and I didn't stop to look
at the code yet to know if it is desired.  Regardless, it should be in a
separate patch anyway as it has nothing to do with the removal of the
log message, so please drop it.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh