linux-kernel - Re: [patch] amd64_edac: shift wrapping issue in f1x_get_norm_dct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Jan 2016 09:29:55 -0600
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>,
	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Doug Thompson <dougthompson@...ssion.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	<linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [patch] amd64_edac: shift wrapping issue in
 f1x_get_norm_dct_addr()

On 1/21/2016 6:32 AM, Borislav Petkov wrote:
> On Wed, Jan 20, 2016 at 12:54:51PM +0300, Dan Carpenter wrote:
>> +	u64 dct_sel_base_off	= (u64)(pvt->dct_sel_hi & 0xFFFFFC00) << 16;
>
>
> @Aravind: do you have a box with
>
> setpci -s 18.2 0x114.l
>
> bits [31:16] not 0?
>
>
>

Nope. I don't see it set on my Fam10h and Fam15h Model 00-0fh systems.

But yes, nice catch!

-Aravind.