linux-kernel - Re: [PATCH] libnvdimm, nfit: Use ACPI_SIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160121160841.GA625@linux.intel.com>
Date:	Thu, 21 Jan 2016 09:08:41 -0700
From:	Ross Zwisler <ross.zwisler@...ux.intel.com>
To:	"Lee, Chun-Yi" <joeyli.kernel@...il.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>, linux-nvdimm@...ts.01.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Lee, Chun-Yi" <jlee@...e.com>,
	Ross Zwisler <ross.zwisler@...ux.intel.com>,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded
 string

On Thu, Jan 21, 2016 at 08:32:10PM +0800, Lee, Chun-Yi wrote:
> It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
> coded string.
> 
> Cc: Ross Zwisler <ross.zwisler@...ux.intel.com>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Len Brown <lenb@...nel.org>
> Signed-off-by: Lee, Chun-Yi <jlee@...e.com>

Acked-by: Ross Zwisler <ross.zwisler@...ux.intel.com>

>  drivers/acpi/nfit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
> index aa45d48..9fb1a6a 100644
> --- a/drivers/acpi/nfit.c
> +++ b/drivers/acpi/nfit.c
> @@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
>  	acpi_size sz;
>  	int rc;
>  
> -	status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
> +	status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
>  	if (ACPI_FAILURE(status)) {
>  		/* This is ok, we could have an nvdimm hotplugged later */
>  		dev_dbg(dev, "failed to find NFIT at startup\n");
> -- 
> 2.1.4
>