linux-kernel - Re: [Resend PATCH V5 1/1] NTB: Add support for AMD PCI-Express Non-Transparent Bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPoiz9wgJBT4UCG6V1eAX_vVLaK=rWuppNXsR=2cYpQrBXLf9g@mail.gmail.com>
Date:	Thu, 21 Jan 2016 11:37:21 -0500
From:	Jon Mason <jdmason@...zu.us>
To:	"Yu, Xiangliang" <Xiangliang.Yu@....com>
Cc:	"Hubbe, Allen" <Allen.Hubbe@....com>,
	"dave.jiang@...el.com" <dave.jiang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-ntb@...glegroups.com" <linux-ntb@...glegroups.com>,
	SPG_Linux_Kernel <SPG_Linux_Kernel@....com>
Subject: Re: [Resend PATCH V5 1/1] NTB: Add support for AMD PCI-Express
 Non-Transparent Bridge

On Thu, Jan 21, 2016 at 2:24 AM, Yu, Xiangliang <Xiangliang.Yu@....com> wrote:
>> From: Xiangliang Yu <Xiangliang.Yu@....com>
>>
>> > Signed-off-by: Xiangliang Yu <Xiangliang.Yu@....com>
>>
>> Yes.
>>
>> > Reviewed-by: Jon Mason <jdmason@...zu.us>
>>
>> Maybe, but that's for Jon to decide.  If he accepts it, he will add signed-off-by,
>> but again, that's for Jon to decide.
>
> Jon also spend a lot of time to review the code, I think should show his working
> On this patch.

I appreciate you trying to give me credit for the review of this code,
but this is not how it works.  Please read
Documentation/SubmittingPatches
"Reviewed-by:, instead, indicates that the patch has been reviewed and
found acceptable according to the Reviewer's Statement:"

While I am content with this patch, you cannot say that for me :)

Thanks,
Jon

>
>> > Reviewed-by: Allen Hubbe <Allen.Hubbe@....com>
>>
>> Adding my reviewed-by is hardly a reason to resend the whole patch.
>
> It will make work easier if merging.
>