linux-kernel - Re: [PATCH] spi: qup: provide proper bus numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Jan 2016 18:38:10 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	Andy Gross <andy.gross@...aro.org>, linux-spi@...r.kernel.org,
	David Brown <david.brown@...aro.org>,
	linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: qup: provide proper bus numbers

On Thu, Jan 21, 2016 at 06:33:47PM +0000, Srinivas Kandagatla wrote:

> This driver reuses pdev->id for spi bus numbers resulting in random
> or very large bus numbering when used with device trees. pdev->id
> is not the correct choice when using device trees. So add code to

What makes you say this, why is pdev->id not "correct"?  It is worrying
if anything cares what number we pick.

> get bus numbers via device tree aliases and if it fails then generate
> a unique bus number.

The other question is even if this is a good idea why is it something
that should be open coded in individual drivers, if we want to change
the policy we should be consistent between drivers.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)