linux-kernel - Re: [PATCH 4/5] x86/alternatives: Add an auxilary section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A12D2D.8060802@zytor.com>
Date:	Thu, 21 Jan 2016 11:10:37 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Andy Lutomirski <luto@...capital.net>,
	Brian Gerst <brgerst@...il.com>, X86 ML <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] x86/alternatives: Add an auxilary section

On 01/21/16 11:07, Borislav Petkov wrote:
> On Thu, Jan 21, 2016 at 11:00:03AM -0800, H. Peter Anvin wrote:
>> NAK on this being part of .altinstr_replacement (if anything it ought to
>> simply be part of .text.init).  Otherwise fine.
> 
> You mean .init.text. Brian had it there in his original version. Out of
> curiosity, why don't you want it in .altinstr_replacement? To avoid any
> mixup?
> 

We covered that already:

.altinstr_replacement doesn't need to be +X (and shouldn't be, but
that's another patch.)

.altinstr_replacement is also "special" in that all the instructions are
offset and not run in place.  These are just plain code stubs and are
executed in place, as is.  The only reason to have a special section for
these at all is to avoid the "init code referenced from non-init-code"
warning.

	-hpa