linux-kernel - Re: [PATCH] staging: iio: replace clk_get() with devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160121194651.GA5325@mwanda>
Date:	Thu, 21 Jan 2016 22:46:51 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Matt Ranostay <mranostay@...il.com>
Cc:	"Gujulan Elango, Hari Prasath (H.)" <hgujulan@...teon.com>,
	"daniel.baluta@...el.com" <daniel.baluta@...el.com>,
	"ciorneiioana@...il.com" <ciorneiioana@...il.com>,
	"lars@...afoo.de" <lars@...afoo.de>,
	"hamohammed.sa@...il.com" <hamohammed.sa@...il.com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"pmeerw@...erw.net" <pmeerw@...erw.net>,
	"knaack.h@....de" <knaack.h@....de>,
	"jic23@...nel.org" <jic23@...nel.org>
Subject: Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()

On Thu, Jan 21, 2016 at 11:21:53AM -0800, Matt Ranostay wrote:
> > @@ -356,8 +356,6 @@ static int spear_adc_probe(struct platform_device *pdev)
> >
> >  errout3:
> >         clk_disable_unprepare(st->clk);
> 
> Shouldn't errout3 now be errout2.. having a gap would seem odd.
> 
> > -errout2:
> > -       clk_put(st->clk);
> >  errout1:
> >         iounmap(st->adc_base_spear6xx);

GW-BASIC style numbered gotos are nonsense.  Label names should be name
after what the label does.

err_unprepare:
err_put:
err_iounmap:

But that's something for a different patch, not related to this patch.

regards,
dan carpenter