linux-kernel - Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160121200905.GB2507@joana>
Date:	Thu, 21 Jan 2016 18:09:05 -0200
From:	Gustavo Padovan <gustavo.padovan@...labora.co.uk>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Gustavo Padovan <gustavo@...ovan.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...hat.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dma-buf/fence: fix timeline str value on
 fence_annotate_wait_on

2016-01-21 Greg KH <gregkh@...uxfoundation.org>:

> On Thu, Jan 21, 2016 at 09:48:14AM -0200, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> > 
> > timeline was wrongly assigned with ->get_driver_name().
> > 
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> > ---
> >  include/trace/events/fence.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h
> > index 98feb1b..d6dfa05 100644
> > --- a/include/trace/events/fence.h
> > +++ b/include/trace/events/fence.h
> > @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on,
> >  
> >  	TP_STRUCT__entry(
> >  		__string(driver, fence->ops->get_driver_name(fence))
> > -		__string(timeline, fence->ops->get_driver_name(fence))
> > +		__string(timeline, fence->ops->get_timeline_name(fence))
> >  		__field(unsigned int, context)
> >  		__field(unsigned int, seqno)
> 
> Why would you send this to: me?  I am not the trace maintainer...

Because you are the original committer of the file. But this should have
been addressed to the trace maintainer.

	Gustavo