linux-kernel - Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160121202205.GA20324@nl1lxl-107192.ttg.global>
Date:	Thu, 21 Jan 2016 21:22:05 +0100
From:	Oreste Salerno <oreste.salerno@...tom.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	<linux-kernel@...r.kernel.org>, <linux-input@...r.kernel.org>,
	<fery@...ress.com>, <robh+dt@...nel.org>, <pawel.moll@....com>,
	<mark.rutland@....com>, <ijc+devicetree@...lion.org.uk>,
	<galak@...eaurora.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource
 allocations

On Thu, Jan 21, 2016 at 11:29:24AM -0800, Dmitry Torokhov wrote:
> Hi Oreste,
> 
> On Thu, Jan 21, 2016 at 08:21:13PM +0100, Oreste Salerno wrote:
> > Use devm_() functions for allocating memory, input device and IRQ.
> > 
> 
> ...
> 
> > @@ -625,11 +620,8 @@ EXPORT_SYMBOL_GPL(cyttsp_probe);
> >  
> >  void cyttsp_remove(struct cyttsp *ts)
> >  {
> > -	free_irq(ts->irq, ts);
> > -	input_unregister_device(ts->input);
> >  	if (ts->pdata->exit)
> >  		ts->pdata->exit();
> > -	kfree(ts);
> 
> This is not quite correct as it changes the operations order... Given
> that it is going to be removed in the next patch I guess it is OK, but
> ideally you can add a custom devm action to shut off the chip.
>

You mean a devm action to call pdata->exit() ? OK, I could do that.

> Thanks.
> 
> -- 
> Dmitry