linux-kernel - Re: [PATCH V2] x86: use enum cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A147F9.1000306@zytor.com>
Date:	Thu, 21 Jan 2016 13:04:57 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Borislav Petkov <bp@...en8.de>,
	Huaitong Han <huaitong.han@...el.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, david.vrabel@...rix.com,
	rusty@...tcorp.com.au, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] x86: use enum cpuid_leafs instead of magic numbers

On 01/21/16 03:42, Borislav Petkov wrote:
> On Thu, Jan 21, 2016 at 07:02:40PM +0800, Huaitong Han wrote:
>> v2:add a commit message.
>>
>> Most of magic numbers of x86_capability have been converted to enum
>> cpuid_leafs, and this patch does update the remaining part.
>>
>> Signed-off-by: Huaitong Han <huaitong.han@...el.com>
>> ---
>>  arch/x86/include/asm/elf.h | 2 +-
>>  arch/x86/kernel/mpparse.c  | 2 +-
>>  arch/x86/lguest/boot.c     | 2 +-
>>  arch/x86/xen/enlighten.c   | 2 +-
>>  4 files changed, 4 insertions(+), 4 deletions(-)
> 

I'm wondering, though, if it wouldn't be better to turn these into
macros so that they can be used in assembly code.  That way the
definitions can be interspersed with the X86_FEATURE_ definitions, too.

	-hpa