linux-kernel - Re: [PATCH V2] x86: use enum cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A14FA0.6090700@zytor.com>
Date:	Thu, 21 Jan 2016 13:37:36 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Huaitong Han <huaitong.han@...el.com>, tglx@...utronix.de,
	mingo@...hat.com, david.vrabel@...rix.com, rusty@...tcorp.com.au,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] x86: use enum cpuid_leafs instead of magic numbers

On 01/21/16 13:33, Borislav Petkov wrote:
> On Thu, Jan 21, 2016 at 01:25:22PM -0800, H. Peter Anvin wrote:
>> See X86_CAPABILITY in head_32.S for example.
> 
> ... so that you can get rid of the offset games at least for
> CPUINFO_x86_capability in asm-offsets_32.c?
> 

No, you still need to be able to find the beginning of the capability
array, but the point is that right now it is implicit in that code that
CPUID_1_EDX == 0.

	-hpa