linux-kernel - Re: [RFC PATCH 0/5] x86/cpufeature: Cleanups and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMzpN2jwN4XKz-C-ys+dNMAcnWL3=a5ykcQ+4fPEJALKumDvgw@mail.gmail.com>
Date:	Thu, 21 Jan 2016 16:53:12 -0500
From:	Brian Gerst <brgerst@...il.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Andy Lutomirski <luto@...capital.net>, X86 ML <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 0/5] x86/cpufeature: Cleanups and improvements

On Thu, Jan 21, 2016 at 1:34 PM, Borislav Petkov <bp@...en8.de> wrote:
> From: Borislav Petkov <bp@...e.de>
>
> So here's the first version of what we talked about. I've ran randbuilds
> on it for a night because of patch 1 with all the header reorg and we
> all know how that can be painful. So this version passes all randbuild
> configs I had generated.
>
> In talking about patch 1, it is a bit big but if you look at the
> diffstat, it basically is fixing a bunch of includes and the meat of it
> being the carving out of the X86_FEATURE_* things to a separate file.
>
> Rest of the patches should be pretty self-explanatory, check the
> respective commit messages.
>
> I haven't tested it functionally yet (booting in kvm doesn't really
> count) - thus the RFC tag. I thought I should send it out first so that
> people can doublecheck me on the direction this is going.
>
> Thanks!
>
> Borislav Petkov (4):
>   x86/cpufeature: Carve out X86_FEATURE_*
>   x86/cpufeature: Remove static_cpu_has()
>   x86/cpufeature: Get rid of the non-asm goto variant
>   x86/alternatives: Add an auxilary section
>
> Brian Gerst (1):
>   x86/alternatives: Discard dynamic check after init

Tested it and it works.  Looks good to me.  Only thing was it didn't
apply to tip/master due to a new cpuid flag added.

--
Brian Gerst