linux-kernel - Re: [PATCH] raid6/algos.c : bug fix : Add the missing definitions to the pq.h file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160121230535.GA31453@kernel.org>
Date:	Thu, 21 Jan 2016 15:05:35 -0800
From:	Shaohua Li <shli@...nel.org>
To:	Gayatri Kammela <gayatri.kammela@...el.com>
Cc:	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
	NeilBrown <neilb@...e.com>, Anton Blanchard <anton@...ba.org>,
	Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH] raid6/algos.c : bug fix : Add the missing definitions to
 the pq.h file

On Thu, Jan 21, 2016 at 02:02:39PM -0800, Gayatri Kammela wrote:
> Adding these pr_info and pr_err definitions so as to allow code to be
> compiled successfully for testing in userspace, since the printk has
> been replaced by pr_info and pr_err in algos.c
> 
> Absence of these definitions result in the compilation errors
> such as ' undefined reference to `pr_info' ' ' undefined reference to
> `pr_err' '
> 
> Cc: NeilBrown <neilb@...e.com>
> Cc: Anton Blanchard <anton@...ba.org>
> Cc: Fenghua Yu <fenghua.yu@...el.com>
> Signed-off-by: Gayatri Kammela <gayatri.kammela@...el.com>
> ---
>  include/linux/raid/pq.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/raid/pq.h b/include/linux/raid/pq.h
> index a7a06d1dcf9c..a0118d5929a9 100644
> --- a/include/linux/raid/pq.h
> +++ b/include/linux/raid/pq.h
> @@ -152,6 +152,8 @@ void raid6_dual_recov(int disks, size_t bytes, int faila, int failb,
>  
>  # define jiffies	raid6_jiffies()
>  # define printk 	printf
> +# define pr_err(format, ...) fprintf(stderr, format, ## __VA_ARGS__)
> +# define pr_info(format, ...) fprintf(stdout, format, ## __VA_ARGS__)
>  # define GFP_KERNEL	0
>  # define __get_free_pages(x, y)	((unsigned long)mmap(NULL, PAGE_SIZE << (y), \
>  						     PROT_READ|PROT_WRITE,   \

Applied, thanks!