linux-kernel - Re: [PATCH, REGRESSION v3] mm: make apply_to_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56A1D67C.9080301@iki.fi>
Date:	Fri, 22 Jan 2016 09:13:00 +0200
From:	Pekka Enberg <penberg@....fi>
To:	David Rientjes <rientjes@...gle.com>,
	Mika Penttilä <mika.penttila@...tfour.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
	Pekka Enberg <penberg@...nel.org>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

On 01/22/2016 01:12 AM, David Rientjes wrote:
> NACK to your patch as it is just covering up buggy code silently. The 
> problem needs to be addressed in change_memory_common() to return if 
> there is no size to change (numpages == 0). It's a two line fix to 
> that function. 

So add a WARN_ON there to *warn* about the situations. There's really no 
need to BUG_ON here.

- Pekka