[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160122094153.GC27246@krava.brq.redhat.com>
Date: Fri, 22 Jan 2016 10:41:53 +0100
From: Jiri Olsa <jolsa@...hat.com>
To: Andi Kleen <andi@...stfloor.org>
Cc: acme@...nel.org, jolsa@...nel.org, mingo@...nel.org,
linux-kernel@...r.kernel.org, eranian@...gle.com,
Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 3/9] perf, tools, stat: Move noise/running printing into
printout
On Tue, Jan 19, 2016 at 06:26:46PM -0800, Andi Kleen wrote:
SNIP
> uval = avg * counter->scale;
> - printout(-1, 0, counter, uval, prefix);
> -
> - print_noise(counter, avg);
> -
> - print_running(avg_running, avg_enabled);
> + printout(-1, 0, counter, uval, prefix, avg_running, avg_enabled, avg);
> fprintf(output, "\n");
> }
>
> @@ -1037,36 +1006,8 @@ static void print_counter(struct perf_evsel *counter, char *prefix)
> if (prefix)
> fprintf(output, "%s", prefix);
>
> - if (run == 0 || ena == 0) {
> - fprintf(output, "CPU%*d%s%*s%s",
> - csv_output ? 0 : -4,
> - perf_evsel__cpus(counter)->map[cpu], csv_sep,
> - csv_output ? 0 : 18,
> - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> - csv_sep);
this hunk is not preserved in the new code.. I guess the output is
different for -A if counter wasn't meassure?
thanks,
jirka
Powered by blists - more mailing lists