[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <56A1F8BB.9090803@nvidia.com>
Date: Fri, 22 Jan 2016 15:09:07 +0530
From: Laxman Dewangan <ldewangan@...dia.com>
To: Javier Martinez Canillas <javier@....samsung.com>,
<linux-kernel@...r.kernel.org>
CC: Kukjin Kim <kgene@...nel.org>, <rtc-linux@...glegroups.com>,
Chanwoo Choi <cw00.choi@...sung.com>,
Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
Krzysztof Kozlowski <k.kozlowski@...sung.com>,
<linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v2 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current
array length
On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote:
> It is better to use the ARRAY_SIZE() macro instead of the array length
> to avoid bugs if the array is later changed and the length not updated.
>
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>
>
Acked-by: Laxman Dewangan <ldewangan@...dia.com>
Similar stuffs are there on multiple places:
u8 data[RTC_NR_TIME];
:::
ret = regmap_bulk_read(info->max77686->rtc_regmap,
MAX77686_ALARM1_SEC, data, RTC_NR_TIME);
Should we say:
ret = regmap_bulk_read(info->max77686->rtc_regmap,
MAX77686_ALARM1_SEC, data,
ARRAY_SIZE(data));
Powered by blists - more mailing lists