linux-kernel - Re: [PATCH 2/2] f2fs: enhance foreground GC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201601221856.kIf9q6Kq%fengguang.wu@intel.com>
Date:	Fri, 22 Jan 2016 18:12:20 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Chao Yu <chao2.yu@...sung.com>
Cc:	kbuild-all@...org, Jaegeuk Kim <jaegeuk@...nel.org>,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] f2fs: enhance foreground GC

Hi Chao,

[auto build test WARNING on f2fs/dev]
[also build test WARNING on v4.4 next-20160121]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Chao-Yu/f2fs-correct-search-area-in-get_new_segment/20160122-174633
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs dev
config: i386-randconfig-s0-201603 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   fs/f2fs/gc.c: In function 'do_garbage_collect':
>> fs/f2fs/gc.c:807:6: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized]
      if (type == SUM_TYPE_NODE) {
         ^

vim +/type +807 fs/f2fs/gc.c

   791			 *                                  - lock_page(sum_page)
   792			 */
   793	
   794			if (type == SUM_TYPE_NODE)
   795				gc_node_segment(sbi, sum->entries, segno, gc_type);
   796			else
   797				gc_data_segment(sbi, sum->entries, gc_list, segno,
   798									gc_type);
   799	
   800			stat_inc_seg_count(sbi, type, gc_type);
   801			stat_inc_call_count(sbi->stat_info);
   802	
   803			f2fs_put_page(sum_page, 0);
   804		}
   805	
   806		if (gc_type == FG_GC) {
 > 807			if (type == SUM_TYPE_NODE) {
   808				struct writeback_control wbc = {
   809					.sync_mode = WB_SYNC_ALL,
   810					.nr_to_write = LONG_MAX,
   811					.for_reclaim = 0,
   812				};
   813				sync_node_pages(sbi, 0, &wbc);
   814			} else {
   815				f2fs_submit_merged_bio(sbi, DATA, WRITE);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (28879 bytes)