linux-kernel - Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Jan 2016 14:15:37 +0200
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Måns Rullgård <mans@...sr.com>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Julian Margetson <runaway@...dw.ms>, Tejun Heo <tj@...nel.org>,
	linux-ide@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find
 dma channel

On Fri, Jan 22, 2016 at 2:05 PM, Måns Rullgård <mans@...sr.com> wrote:
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>> On Fri, 2016-01-22 at 11:13 +0000, Måns Rullgård wrote:
>>> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>>> > On Wed, 2016-01-20 at 20:07 +0000, Måns Rullgård wrote:
>>> > > Andy Shevchenko <andy.shevchenko@...il.com> writes:

>> +               u8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ?    \
>> +                          _dwc->p_master : _dwc->m_master;                     \
>> +               u8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ?    \
>> +                          _dwc->p_master : _dwc->m_master;                     \

> Oh, I see it now.  Two lines have a space rather than a tab since a tab
> would push them over 80 columns.  Now those lines could be shortened by
> simply dropping the "_is_slave" since this is necessarily true if the
> other half of the && is.

Yes, direction is precisely from the _is_slave space.

-- 
With Best Regards,
Andy Shevchenko