linux-kernel - Re: [PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A25E5D.6050504@atmel.com>
Date:	Fri, 22 Jan 2016 17:52:45 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Cyrille Pitchen <cyrille.pitchen@...el.com>,
	<herbert@...dor.apana.org.au>, <davem@...emloft.net>
CC:	<linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 0/5] crypto: atmel-sha: fix registration issue and other
 bugs

Le 15/01/2016 15:49, Cyrille Pitchen a écrit :
> Hi all,
> 
> This series of patches fixes many issues such as the algo registration failure
> or the broken support of context switches.

I think it's eligible as a "fixes" series for 4.5... Herbert, is the
whole series can be queued as fixes, in your opinion?

And, on the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>


> This series was applied to linux-next and tested on a sama5d2 xplained
> ultra board. We now pass the tcrypt tests in the following modes:
> -  2: sha1
> -  6: sha256
> - 11: sha384
> - 12: sha512
> - 33: sha224
> 
> The context switch fix was tested with a userspace program using the cryptodev
> module. This single thread program computes the SHA256 hashes of many files
> by splitting then into fixed size chunks. The chunks of each file are
> processed by calling 'update' operations using a round robin algorithm.
> 
> However, the .import() / .export() implementation was NOT tested!
> Nonetheless the last patch is needed to fix the registration issue, otherwise
> atmel_sha_probe() would still fail.
> 
> Best regards,
> 
> Cyrille
> 
> 
> Cyrille Pitchen (5):
>   crypto: atmel-sha: fix crash when computing digest on empty message
>   crypto: atmel-sha: fix a race between the 'done' tasklet and the
>     crypto client
>   crypto: atmel-sha: add support of sama5d2x SoCs
>   crypto: atmel-sha: fix context switches
>   crypto: atmel-sha: fix algorihtm registration
> 
>  drivers/crypto/atmel-sha-regs.h |   4 +
>  drivers/crypto/atmel-sha.c      | 186 +++++++++++++++++++++++++++++++++-------
>  2 files changed, 158 insertions(+), 32 deletions(-)
> 


-- 
Nicolas Ferre