linux-kernel - Re: [PATCH] block: fix bio splitting on max sectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Jan 2016 20:11:17 +0000
From:	Keith Busch <keith.busch@...el.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Ming Lei <tom.leiming@...il.com>, Jens Axboe <axboe@...nel.dk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-block@...r.kernel.org,
	Stefan Haberland <sth@...ux.vnet.ibm.com>
Subject: Re: [PATCH] block: fix bio splitting on max sectors

On Fri, Jan 22, 2016 at 10:43:59AM -0800, Linus Torvalds wrote:
> On Fri, Jan 22, 2016 at 10:29 AM, Ming Lei <tom.leiming@...il.com> wrote:
> >
> > This patch fixes the issue by making the max io size aligned
> > to logical block size.
> 
> Looks better, thanks.
> 
> I'd suggest also moving the "max_sectors" variable into the
> bio_for_each_segment() loop too just to keep variables with minimal
> scope, but at least this is fairly legible.

The value of max_sectors doesn't change in this function, so its
calculation could be done just once instead of with each segment
iteration.

Other than that, thanks Ming, the fix looks good to me. Third try's
a charm?