linux-kernel - Re: [PATCH] block: fix bio splitting on max sectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzJnZE9D=FK-dMb_rkOOwiEorxnjPFDuve7g6H+hBO46g@mail.gmail.com>
Date:	Fri, 22 Jan 2016 12:32:33 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Keith Busch <keith.busch@...el.com>
Cc:	Stefan Haberland <sth@...ux.vnet.ibm.com>,
	Jens Axboe <axboe@...nel.dk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-block@...r.kernel.org, Ming Lei <tom.leiming@...il.com>
Subject: Re: [PATCH] block: fix bio splitting on max sectors

[ Grr. re-sending due to stupid html from android mobile app. ]

On Jan 22, 2016 12:11 PM, "Keith Busch" <keith.busch@...el.com> wrote:
>
> The value of max_sectors doesn't change in this function

Why do you say that? It depends on the offset, so it clearly *does* change.

Now, if the patch did what I suggested and made max_sector and the cluster
size thing be separate, then *those* would indeed be constant over the whole
function.

      Linus