linux-kernel - Re: [PATCH 2.6.32 40/42] mm/memory_hotplug.c: check for missing sections in test_pages_in_a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1453572839.3734.170.camel@decadent.org.uk>
Date:	Sat, 23 Jan 2016 18:13:59 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Willy Tarreau <w@....eu>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Cc:	Andrew Banman <abanman@....com>, Alex Thorlton <athorlton@....com>,
	Russ Anderson <rja@....com>, Yinghai Lu <yinghai@...nel.org>,
	Greg KH <greg@...ah.com>,
	Seth Jennings <sjennings@...iantweb.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 2.6.32 40/42] mm/memory_hotplug.c: check for missing
 sections in test_pages_in_a_zone()

On Sat, 2016-01-23 at 15:13 +0100, Willy Tarreau wrote:
> 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Andrew Banman <abanman@....com>
> 
> commit 5f0f2887f4de9508dcf438deab28f1de8070c271 upstream.
[...]
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index f4be464..de19654 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -601,23 +601,30 @@ int is_mem_section_removable(unsigned long start_pfn, unsigned long nr_pages)
>   */
>  static int test_pages_in_a_zone(unsigned long start_pfn, unsigned long end_pfn)
>  {
> -	unsigned long pfn;
> +	unsigned long pfn, sec_end_pfn;
>  	struct zone *zone = NULL;
>  	struct page *page;
>  	int i;
> -	for (pfn = start_pfn;
> +	for (pfn = start_pfn, sec_end_pfn = SECTION_ALIGN_UP(start_pfn);
[...]

SECTION_ALIGN_UP() is not defined in 2.6.32; it was added by commit
a539f3533b78.

Ben.

-- 
Ben Hutchings
Life is what happens to you while you're busy making other plans.
                                                               - John Lennon
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)