linux-kernel - Re: [PATCH] vt: correctly check return value of class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160123235147.GC32511@kroah.com>
Date:	Sat, 23 Jan 2016 15:51:47 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Insu Yun <wuninsu@...il.com>
Cc:	jslaby@...e.com, linux-kernel@...r.kernel.org, taesoo@...ech.edu,
	yeongjin.jang@...ech.edu, insu@...ech.edu, changwoo@...ech.edu
Subject: Re: [PATCH] vt: correctly check return value of class_create

On Sat, Jan 23, 2016 at 03:52:46PM -0500, Insu Yun wrote:
> Since class_create can be failed in memory pressure,

In this case, really?  At init time?

> its return value should be checked and correctly handled.

You didn't correctly handle it, you leaked memory and other resources :(