linux-kernel - Re: [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160124113318.GB1775@katana>
Date:	Sun, 24 Jan 2016 12:33:18 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Sricharan <sricharan@...eaurora.org>
Cc:	devicetree@...r.kernel.org, architt@...eaurora.org,
	linux-arm-msm@...r.kernel.org, ntelkar@...eaurora.org,
	galak@...eaurora.org, linux-kernel@...r.kernel.org,
	andy.gross@...aro.org, linux-i2c@...r.kernel.org,
	iivanov@...sol.com, agross@...eaurora.org,
	dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma

> > Sricharan R (6):
> >   i2c: qup: Change qup_wait_writeready function to use for all timeouts
> >   i2c: qup: Add V2 tags support
> >   i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit
> >   i2c: qup: Add bam dma capabilities
> >   dts: msm8974: Add blsp2_bam dma node
> >   dts: msm8974: Add dma channels for blsp2_i2c1 node
> > 
>  Wolfram,  Does the first 4 patches looks good to be picked up  ?

Except for patch 3 (I replied seperately), the rest looks okay to me. I
wondered a little if it would make sense to make a new driver for v2 +
DMA, because the additions were quite massive. But I'll leave it up to
you if there is enough shared code between the two versions, so that a
single driver will be better.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)