linux-kernel - Re: [PATCH 1/4] arm: Fix wrong bounds check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A66B74.1060103@redhat.com>
Date:	Mon, 25 Jan 2016 10:37:40 -0800
From:	Laura Abbott <labbott@...hat.com>
To:	mika.penttila@...tfour.com, linux-kernel@...r.kernel.org
Cc:	linux-mm@...ck.org, rientjes@...gle.com, linux@....linux.org.uk
Subject: Re: [PATCH 1/4] arm: Fix wrong bounds check.

On 01/23/2016 07:05 AM, mika.penttila@...tfour.com wrote:
> From: Mika Penttilä <mika.penttila@...tfour.com>
>
> Not related to this oops, but while at it, fix incorrect bounds check.
>
> Signed-off-by: Mika Penttilä mika.penttila@...tfour.com
>
> ---
>   arch/arm/mm/pageattr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mm/pageattr.c b/arch/arm/mm/pageattr.c
> index cf30daf..be7fe4b 100644
> --- a/arch/arm/mm/pageattr.c
> +++ b/arch/arm/mm/pageattr.c
> @@ -52,7 +52,7 @@ static int change_memory_common(unsigned long addr, int numpages,
>   	if (start < MODULES_VADDR || start >= MODULES_END)
>   		return -EINVAL;
>
> -	if (end < MODULES_VADDR || start >= MODULES_END)
> +	if (end < MODULES_VADDR || end >= MODULES_END)
>   		return -EINVAL;
>
>   	data.set_mask = set_mask;
>

This has been submitted a few times before, not sure if it is pending
in Russell's patch tracker or nobody has actually submitted it to the
patch tracker.

Russell, is this pending somewhere already?

Thanks,
Laura