linux-kernel - Re: [PATCH 6/6] x86/vdso: Use static_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrUt42BNJEY+dskCKF8Tmwu0keMo0L-faxefMKBcKRGRFg@mail.gmail.com>
Date:	Mon, 25 Jan 2016 10:45:30 -0800
From:	Andy Lutomirski <luto@...capital.net>
To:	Borislav Petkov <bp@...en8.de>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Brian Gerst <brgerst@...il.com>,
	X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] x86/vdso: Use static_cpu_has()

On Sun, Jan 24, 2016 at 1:28 AM, Borislav Petkov <bp@...en8.de> wrote:
> From: Borislav Petkov <bp@...e.de>
>
> ... and simplify and speed up a tad.

This function is only used when initializing CPUs, so the "tad" is
very small indeed.

If there are systems for which some cpus support rdtscp and some
don't, then this patch is wrong.  Of course, if the bsp has rdtscp and
the aps don't, then we're screwed anyway.  I left it as cpu_has
because this is a cpu init function and it seemed reasonable.

That being said, I have no meaningful objection to this patch.

--Andy